Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1989483002: MIPS64: Fix 'Remove usages of Heap::NewSpaceStart and its external reference'. (Closed)

Created:
4 years, 7 months ago by balazs.kilvady
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix 'Remove usages of Heap::NewSpaceStart and its external reference'. Port f2a585935fa070d2b4fb78389045d4df5253dd96 Original commit message: Replace the uses with proper page flag lookups. BUG=chromium:581412 LOG=N TEST=mjsunit/allocation-site-info Committed: https://crrev.com/bbb8ff1907b9d07872712513e14525951ae9ae1d Cr-Commit-Position: refs/heads/master@{#36289}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/mips64/macro-assembler-mips64.cc View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
4 years, 7 months ago (2016-05-17 15:53:05 UTC) #2
akos.palfi.imgtec
Lgtm
4 years, 7 months ago (2016-05-17 16:28:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989483002/1
4 years, 7 months ago (2016-05-17 16:37:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 17:06:27 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:08:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bbb8ff1907b9d07872712513e14525951ae9ae1d
Cr-Commit-Position: refs/heads/master@{#36289}

Powered by Google App Engine
This is Rietveld 408576698