Issue 1989463003: Add back join of windows eventhandler threads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1989463003: Add back join of windows eventhandler threads (Closed)

Created:
4 years, 7 months ago by zra

Modified:
4 years, 7 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add back join of windows eventhandler threads These threads are polluting the exit code despite using the better ExitProcess call. Instead of adding back Thread::Join, I've instead inlined the call into the eventhandler to make it easier to be sure the open handles are closed. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/18ec8dddd913398215747e7de3ecfb7f35c62e1c

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -6 lines)			Patch
	M	runtime/bin/eventhandler_win.h	View		4 chunks	+4 lines, -0 lines	0 comments	Download
	M	runtime/bin/eventhandler_win.cc	View		8 chunks	+32 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

4 years, 7 months ago (2016-05-17 21:54:00 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
18ec8dddd913398215747e7de3ecfb7f35c62e1c (presubmit successful).