Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1989463002: Deprecate invoking the default action for untrusted events. (Closed)

Created:
4 years, 7 months ago by dtapuska
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master_dom_event_deprecation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate invoking the default action for untrusted events. Add deprecation for dispatching untrusted events. Intent to deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/OzHI2c2vkEo/9Bz-j4PhBAAJ Chrome status: https://www.chromestatus.com/features/5718803933560832 BUG=520519 Committed: https://crrev.com/d3b017a82b0f7efa12a1919bf073466978f3fb62 Cr-Commit-Position: refs/heads/master@{#394479}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Patch Set 3 : Adjust deprecation message #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/dispatch-synthetic-keyboardevent-no-action-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/simulated-key-state-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventDispatcher.cpp View 2 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Deprecation.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
dtapuska
4 years, 7 months ago (2016-05-17 17:04:24 UTC) #3
Rick Byers
lgtm with nit around warning I also tweaked the chromestatus entry a bit (eg. linked ...
4 years, 7 months ago (2016-05-17 17:34:29 UTC) #4
Ilya Sherman
histograms.xml lgtm
4 years, 7 months ago (2016-05-17 18:18:15 UTC) #5
dtapuska
https://codereview.chromium.org/1989463002/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp File third_party/WebKit/Source/core/frame/Deprecation.cpp (right): https://codereview.chromium.org/1989463002/diff/1/third_party/WebKit/Source/core/frame/Deprecation.cpp#newcode392 third_party/WebKit/Source/core/frame/Deprecation.cpp:392: return willBeRemoved("Performing default actions on untrusted events", 53, "5718803933560832"); ...
4 years, 7 months ago (2016-05-17 19:32:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989463002/40001
4 years, 7 months ago (2016-05-18 13:40:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/7652) ios-simulator on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 7 months ago (2016-05-18 13:42:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989463002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989463002/60001
4 years, 7 months ago (2016-05-18 16:14:56 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-18 18:38:02 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 18:39:34 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d3b017a82b0f7efa12a1919bf073466978f3fb62
Cr-Commit-Position: refs/heads/master@{#394479}

Powered by Google App Engine
This is Rietveld 408576698