Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1989453003: cc: Add ScopedReadLockGpuMemoryBuffer (Closed)

Created:
4 years, 7 months ago by ccameron
Modified:
4 years, 7 months ago
Reviewers:
jbauman
CC:
chromium-reviews, piman+watch_chromium.org, cc-bugs_chromium.org, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add ScopedReadLockGpuMemoryBuffer For resources provided by a child compositor, hook this up to the new CreateGpuMemoryBufferFromClientId function to create a GpuMemoryBufferImpl on the parent side. Update TestGpuMemoryBufferManager to test this (providing a different GpuMemoryBufferManager to the child and parent resource providers). Plumb the GpuMemoryBufferManager client id through from DelegatedFrameHost to the cc::Surface to the cc:ResourceProvider when providing child resources. Note that this will not cover all content (e.g, child frame). A follow-on patch will cover these cases (for now, not-covered content will fall back to OpenGL compositing). BUG=604052 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/529e601dd0e4fbe65b9046da53f48614a9448d07 Cr-Commit-Position: refs/heads/master@{#395040}

Patch Set 1 #

Patch Set 2 : Add GetTextureId function #

Patch Set 3 : Full routing #

Patch Set 4 : Add tests #

Patch Set 5 : Check window server signal #

Patch Set 6 : Fix aura typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -59 lines) Patch
M cc/resources/resource_provider.h View 1 4 chunks +26 lines, -2 lines 0 comments Download
M cc/resources/resource_provider.cc View 1 2 3 8 chunks +49 lines, -6 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 1 2 3 4 22 chunks +191 lines, -38 lines 0 comments Download
M cc/surfaces/surface.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M cc/surfaces/surface.cc View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M cc/surfaces/surface_factory.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M cc/surfaces/surface_factory.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.h View 1 2 3 2 chunks +18 lines, -0 lines 0 comments Download
M cc/test/test_gpu_memory_buffer_manager.cc View 1 2 3 8 chunks +94 lines, -12 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/delegated_frame_host.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
ccameron
ptal. This is the patch that I discussed with you earlier. I've only hooked up ...
4 years, 7 months ago (2016-05-17 20:46:13 UTC) #6
ccameron
ping on this
4 years, 7 months ago (2016-05-19 02:22:25 UTC) #7
jbauman
lgtm
4 years, 7 months ago (2016-05-19 02:41:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989453003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989453003/100001
4 years, 7 months ago (2016-05-20 08:15:06 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 7 months ago (2016-05-20 09:10:51 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 09:12:37 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/529e601dd0e4fbe65b9046da53f48614a9448d07
Cr-Commit-Position: refs/heads/master@{#395040}

Powered by Google App Engine
This is Rietveld 408576698