Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 198943004: Testcase for crbug.com/350907 (Closed)

Created:
6 years, 9 months ago by fs
Modified:
6 years, 9 months ago
Reviewers:
pdr., eseidel
CC:
blink-reviews, krit, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, kouhei+svg_chromium.org, rwlbuis, haraken
Visibility:
Public.

Description

Testcase for crbug.com/350907 Also replace the FIXME with an attempt at explaining why/when m_image can be 0. BUG=350907 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
A LayoutTests/svg/as-image/svg-invalid-image-1.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + LayoutTests/svg/as-image/svg-invalid-image-1-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/svg/graphics/SVGImageChromeClient.cpp View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
fs
This a TC for issue 350907, derived from the fuzzer-produced reproductions in issues 351422 and ...
6 years, 9 months ago (2014-03-13 15:00:49 UTC) #1
pdr.
On 2014/03/13 15:00:49, fs wrote: > This a TC for issue 350907, derived from the ...
6 years, 9 months ago (2014-03-13 18:38:08 UTC) #2
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-13 18:38:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/198943004/1
6 years, 9 months ago (2014-03-13 18:38:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/198943004/1
6 years, 9 months ago (2014-03-14 03:33:59 UTC) #5
commit-bot: I haz the power
Change committed as 169210
6 years, 9 months ago (2014-03-14 05:31:04 UTC) #6
eseidel
I thought we were reverting all the deferred page-destruction stuff?
6 years, 9 months ago (2014-03-14 06:35:06 UTC) #7
eseidel
Thank you for the test, btw.
6 years, 9 months ago (2014-03-14 06:35:37 UTC) #8
Mads Ager (chromium)
6 years, 9 months ago (2014-03-14 07:24:44 UTC) #9
Message was sent while issue was closed.
On 2014/03/14 06:35:06, eseidel wrote:
> I thought we were reverting all the deferred page-destruction stuff?

Yeah, we are going to revert that. I'll send out the revert today and I'll
revert the cpp part of this change as well. It is great to have this test case
though; it will help us catch potential finalization order issue for oilpan, so
thanks a lot for the test!

Powered by Google App Engine
This is Rietveld 408576698