getDeviceCapabilities is no longer need, so remove it

getDeviceCapabilities is no longer need, so remove it

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13797

[bungeman-skia, 2014-03-13 14:08:32]

lgtm

[vandebo (ex-Chrome), 2014-03-13 17:21:17]

LGTM

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h#...
include/core/SkDevice.h:20: // for clients that have "override" annotations on
their subclass. These overrides
Why not do this first?

https://codereview.chromium.org/198943003/diff/10001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/198943003/diff/10001/src/pdf/SkPDFDevice.cpp#...
src/pdf/SkPDFDevice.cpp:1340: // our onCreateDevice() always creates SkPDFDevice
subclasses.
And onCreateDevice() is the only consumer of devices that can be passed to
drawDevice() ?

[vandebo (ex-Chrome), 2014-03-13 17:21:19]

LGTM

[reed1, 2014-03-13 18:15:32]

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h#...
include/core/SkDevice.h:20: // for clients that have "override" annotations on
their subclass. These overrides
On 2014/03/13 17:21:17, vandebo wrote:
> Why not do this first?

I will land this Skia change first, which gives a default impl for the method
(so that clients can remove their overrides).

https://codereview.chromium.org/198943003/diff/10001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

https://codereview.chromium.org/198943003/diff/10001/src/pdf/SkPDFDevice.cpp#...
src/pdf/SkPDFDevice.cpp:1340: // our onCreateDevice() always creates SkPDFDevice
subclasses.
On 2014/03/13 17:21:17, vandebo wrote:
> And onCreateDevice() is the only consumer of devices that can be passed to
> drawDevice() ?

Correct. raster and gpu backends rely on the device always being
one-of-their-own

[vandebo (ex-Chrome), 2014-03-13 18:19:55]

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h
File include/core/SkDevice.h (right):

https://codereview.chromium.org/198943003/diff/10001/include/core/SkDevice.h#...
include/core/SkDevice.h:20: // for clients that have "override" annotations on
their subclass. These overrides
On 2014/03/13 18:15:33, reed1 wrote:
> On 2014/03/13 17:21:17, vandebo wrote:
> > Why not do this first?
> 
> I will land this Skia change first, which gives a default impl for the method
> (so that clients can remove their overrides).

Oh, it's pure virtual, I see.

[reed1, 2014-03-13 18:50:39]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-03-13 18:50:50]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/reed@google.com/198943003/10001

[commit-bot: I haz the power, 2014-03-13 19:38:20]

Change committed as 13797