Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 198943002: Simplify GetEnumPropertyKeys and avoid trimming fixed arrays in large object space. (Closed)

Created:
6 years, 9 months ago by ulan
Modified:
6 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Simplify GetEnumPropertyKeys and avoid trimming fixed arrays in large object space. BUG=352070 LOG=N R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19894

Patch Set 1 #

Patch Set 2 : Fix filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -54 lines) Patch
M src/handles.cc View 1 chunk +3 lines, -26 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +20 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 9 months ago (2014-03-13 11:01:49 UTC) #1
Toon Verwaest
lgtm
6 years, 9 months ago (2014-03-13 11:23:30 UTC) #2
ulan
6 years, 9 months ago (2014-03-13 12:45:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19894 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698