Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None

Committed: https://crrev.com/76a016568a6b224945dd21b04e3eb783673f0e37
Cr-Commit-Position: refs/heads/master@{#395469}

[pkotwicz, 2016-05-19 01:43:18]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2016-05-19 01:44:31]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2016-05-19 01:45:38]

pkotwicz@chromium.org changed reviewers:
+ yfriedman@chromium.org

[pkotwicz, 2016-05-19 01:45:39]

Yaron, can you please take a look?

https://codereview.chromium.org/1989403004/diff/40001/build/android/findbugs_...
File build/android/findbugs_filter/findbugs_exclude.xml (right):

https://codereview.chromium.org/1989403004/diff/40001/build/android/findbugs_...
build/android/findbugs_filter/findbugs_exclude.xml:23: <Bug
pattern="DM_DEFAULT_ENCODING" />
Yaron, what explanation should I give for the suppression?

[Yaron, 2016-05-19 02:06:25]

lgtm

https://codereview.chromium.org/1989403004/diff/40001/build/android/findbugs_...
File build/android/findbugs_filter/findbugs_exclude.xml (right):

https://codereview.chromium.org/1989403004/diff/40001/build/android/findbugs_...
build/android/findbugs_filter/findbugs_exclude.xml:23: <Bug
pattern="DM_DEFAULT_ENCODING" />
On 2016/05/19 01:45:39, pkotwicz wrote:
> Yaron, what explanation should I give for the suppression?

<!-- Legacy code, discouraged on Android:
https://developer.android.com/reference/java/security/AccessController.html -->

[pkotwicz, 2016-05-19 15:53:46]

Description was changed from

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

BUG=None
==========

to

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged.
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

[pkotwicz, 2016-05-19 15:53:46]

pkotwicz@chromium.org changed reviewers:
+ jbudorick@chromium.org, michaelbai@chromium.org

[pkotwicz, 2016-05-19 15:54:01]

Description was changed from

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged.
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

to

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

[pkotwicz, 2016-05-19 15:55:34]

jbudorick@ can you please take a look at the changes in build/android
michaelbai@ can you please take a look at the changes in android_webview

[jbudorick, 2016-05-19 15:56:57]

build/android/ lgtm

[pkotwicz, 2016-05-20 19:32:41]

michaelbai@ Ping!

[michaelbai, 2016-05-20 21:05:35]

sony, miss this, LGTM

[pkotwicz, 2016-05-23 22:22:34]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2016-05-23 22:22:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1989403004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-05-23 22:22:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989403004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989403004/80001

[commit-bot: I haz the power, 2016-05-23 23:56:34]

Description was changed from

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

to

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

[commit-bot: I haz the power, 2016-05-23 23:56:36]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-05-23 23:58:04]

Description was changed from

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None
==========

to

==========
Always suppress DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED

According to the docs, using AccessController is discouraged:
https://developer.android.com/reference/java/security/AccessController.html

BUG=None

Committed: https://crrev.com/76a016568a6b224945dd21b04e3eb783673f0e37
Cr-Commit-Position: refs/heads/master@{#395469}
==========

[commit-bot: I haz the power, 2016-05-23 23:58:05]

Patchset 3 (id:??) landed as
https://crrev.com/76a016568a6b224945dd21b04e3eb783673f0e37
Cr-Commit-Position: refs/heads/master@{#395469}