Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 1989403003: Remove unnecessary 'inline's on constexpr TimeDelta functions. (Closed)

Created:
3 years, 5 months ago by Jeffrey Yasskin
Modified:
3 years, 5 months ago
Reviewers:
danakj, Peter Kasting
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary 'inline's on constexpr TimeDelta functions. [dcl.constexpr]p2 says that constexpr implies inline. Committed: https://crrev.com/a7071a583c21193e85d81b298b4724496c3af71d Cr-Commit-Position: refs/heads/master@{#394593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M base/time/time.h View 2 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Jeffrey Yasskin
3 years, 5 months ago (2016-05-18 21:11:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989403003/1
3 years, 5 months ago (2016-05-18 21:18:34 UTC) #5
danakj
LGTM
3 years, 5 months ago (2016-05-18 22:03:15 UTC) #6
Peter Kasting
LGTM too
3 years, 5 months ago (2016-05-18 22:09:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989403003/1
3 years, 5 months ago (2016-05-18 22:14:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 5 months ago (2016-05-18 23:21:05 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2016-05-18 23:24:09 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7071a583c21193e85d81b298b4724496c3af71d
Cr-Commit-Position: refs/heads/master@{#394593}

Powered by Google App Engine
This is Rietveld 408576698