Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19894003: Move webplugininfo.h to content/public. (Closed)

Created:
7 years, 5 months ago by jam
Modified:
7 years, 5 months ago
Reviewers:
scottmg
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, nkostylev+watch_chromium.org, stuartmorgan+watch_chromium.org, robertshield, Ilya Sherman, jam, dcheng, joi+watch-content_chromium.org, rginda+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, jochen+watch_chromium.org, jar (doing other things)
Visibility:
Public.

Description

Move webplugininfo.h to content/public. BUG=237249 TBR=scottmg Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212812

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+472 lines, -784 lines) Patch
M chrome/browser/automation/testing_automation_provider.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_plugin_browsertest.cc View 1 4 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/component_updater/widevine_cdm_component_installer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_api.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/content_settings/content_settings_apitest.cc View 1 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/plugin_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/hang_monitor/hung_plugin_action.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_log.h View 1 7 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 9 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/metrics/metrics_log_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/metrics_service.h View 1 4 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/pepper_broker_infobar_delegate.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/pepper_flash_settings_manager.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/chrome_plugin_service_filter.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_data_remover_helper.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.h View 1 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_installer.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_installer_unittest.cc View 1 1 chunk +6 lines, -7 lines 1 comment Download
M chrome/browser/plugins/plugin_metadata.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/plugins/plugin_metadata_unittest.cc View 1 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_prefs.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/plugins/plugin_prefs_unittest.cc View 1 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/plugins/plugin_status_pref_setter.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugin_status_pref_setter.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/policy_browsertest.cc View 1 8 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_host/plugin_info_message_filter_unittest.cc View 1 2 3 4 8 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/drag_util.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/pdf/pdf_unsupported_feature.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/flash_ui.cc View 1 5 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/nacl_ui.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_handler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_content_client.cc View 1 8 chunks +27 lines, -27 lines 0 comments Download
M chrome/common/render_messages.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client_unittest.cc View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/plugins/plugin_placeholder.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/risk/fingerprint.cc View 1 2 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/plugin_loader_posix.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/plugin_loader_posix.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/plugin_loader_posix_unittest.cc View 1 10 chunks +12 lines, -18 lines 0 comments Download
M content/browser/plugin_process_host.h View 1 5 chunks +5 lines, -5 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 14 chunks +20 lines, -20 lines 0 comments Download
M content/browser/plugin_service_impl_browsertest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 1 3 chunks +3 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 6 chunks +7 lines, -7 lines 0 comments Download
M content/child/npapi/plugin_host.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_lib.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/child/npapi/plugin_lib.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/npapi/plugin_lib_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_mac.mm View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/common/pepper_plugin_registry.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/pepper_plugin_registry.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M content/common/plugin_list.h View 1 10 chunks +20 lines, -22 lines 0 comments Download
M content/common/plugin_list.cc View 1 13 chunks +14 lines, -19 lines 0 comments Download
M content/common/plugin_list_mac.mm View 1 2 chunks +1 line, -3 lines 0 comments Download
M content/common/plugin_list_posix.cc View 1 2 chunks +1 line, -4 lines 0 comments Download
M content/common/plugin_list_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/plugin_list_win.cc View 1 4 chunks +6 lines, -9 lines 0 comments Download
M content/common/utility_messages.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/view_messages.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + content/common/webplugininfo_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/public/browser/plugin_data_remover.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/public/browser/plugin_service.h View 1 7 chunks +7 lines, -11 lines 0 comments Download
M content/public/browser/plugin_service_filter.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/common/pepper_plugin_info.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
A + content/public/common/webplugininfo.h View 1 3 chunks +8 lines, -7 lines 0 comments Download
A + content/public/common/webplugininfo.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/renderer/content_renderer_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/render_view.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.h View 1 4 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_delegate_impl.cc View 1 5 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_pepper_helper.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_view_pepper_helper.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 1 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_plugin_service_filter.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_plugin_service_filter.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/plugins/webkit_plugins.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D webkit/plugins/webplugininfo.h View 1 chunk +0 lines, -98 lines 0 comments Download
D webkit/plugins/webplugininfo.cc View 1 chunk +0 lines, -103 lines 0 comments Download
D webkit/plugins/webplugininfo_unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
7 years, 5 months ago (2013-07-21 04:28:24 UTC) #1
scottmg
7 years, 5 months ago (2013-07-21 05:03:49 UTC) #2
Message was sent while issue was closed. 
suuuuure, tbr me a cl so that the one i sent you needs to be rebased ;)

lgtm

https://codereview.chromium.org/19894003/diff/21017/chrome/browser/plugins/pl...
File chrome/browser/plugins/plugin_installer_unittest.cc (right):

https://codereview.chromium.org/19894003/diff/21017/chrome/browser/plugins/pl...
chrome/browser/plugins/plugin_installer_unittest.cc:15: content:: WebPluginInfo
plugin(
extra space for sometime

Powered by Google App Engine
This is Rietveld 408576698