components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc - Issue 1989393004: Remove unnecessary DRPConfiguratorTestUtils and add more DRPConfig tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

Issue 1989393004: Remove unnecessary DRPConfiguratorTestUtils and add more DRPConfig tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tarun_test_changes

Patch Set: Fix failing DCHECK Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

index 89a1fafbbc2856b428420c3aa230926a906cec38..c317c1a5fdcf01441755975e03d54fa54acaf380 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_delegate_unittest.cc

@@ -26,7 +26,6 @@

#include "base/values.h"

#include "build/build_config.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h"

-#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_configurator_test_utils.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_metrics.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h"

#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h"

@@ -80,7 +79,6 @@ TEST(DataReductionProxyDelegate, IsTrustedSpdyProxy) {

std::unique_ptr<DataReductionProxyTestContext> test_context =

DataReductionProxyTestContext::Builder()

.WithConfigClient()

- .WithTestConfigurator()

.WithMockDataReductionProxyService()

.Build();