pkg/analysis_server/lib/src/services/completion/dart/optype.dart - Issue 1989393002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/optype.dart

Issue 1989393002: Code completion improvement. Recommend all 'E.x' where E is an enum, also, filter out only the cor… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart ('k') | pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/optype.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/optype.dart b/pkg/analysis_server/lib/src/services/completion/dart/optype.dart

index 3ddc75dbf2f69eee9a7ec984a1e096db833e4327..3a5608c856cbf96ea93e7c24f9976d170a1eca13 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/optype.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/optype.dart

@@ -641,6 +641,16 @@ class _OpTypeAstVisitor extends GeneralizingAstVisitor {

optype.includeReturnValueSuggestions = true;

optype.returnValueSuggestionsFilter = (DartType dartType, int relevance) {

DartType type = node.element?.type;

+ bool isEnum = type != null &&

+ type.element is ClassElement &&

+ (type.element as ClassElement).isEnum;

+ if (isEnum) {

+ if (type == dartType) {

+ return relevance + DART_RELEVANCE_INCREMENT;

+ } else {

+ return null;

+ }

if (type != null &&

dartType != null &&

!type.isDynamic &&