Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989363008: PPC/S390: Fix native build break caused by type mismatch (Closed)

Created:
4 years, 7 months ago by john.yan
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/S390: Fix native build break caused by type mismatch R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/97bfd23874fa5f897bd3dfea3d9c1c9648f6df88 Cr-Commit-Position: refs/heads/master@{#36386}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -8 lines) Patch
M src/ppc/builtins-ppc.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/s390/builtins-s390.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
john.yan
PTAL
4 years, 7 months ago (2016-05-19 20:27:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989363008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989363008/1
4 years, 7 months ago (2016-05-19 20:28:00 UTC) #3
MTBrandyberry
lgtm
4 years, 7 months ago (2016-05-19 20:33:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 21:00:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989363008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989363008/1
4 years, 7 months ago (2016-05-19 21:07:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 21:09:31 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 21:12:09 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/97bfd23874fa5f897bd3dfea3d9c1c9648f6df88
Cr-Commit-Position: refs/heads/master@{#36386}

Powered by Google App Engine
This is Rietveld 408576698