Move predictor dns unit tests to browser tests

chrome/browser/net/predictor.h

Index: chrome/browser/net/predictor.h
diff --git a/chrome/browser/net/predictor.h b/chrome/browser/net/predictor.h
index f9aa90a6a0e1c6b0e1c649f4cea82c77011999b1..78348757f3461ffee28a6a258b9efa6a81acc602 100644
--- a/chrome/browser/net/predictor.h
+++ b/chrome/browser/net/predictor.h
@@ -317,11 +317,11 @@ class Predictor {
   }
 
  private:
-  FRIEND_TEST_ALL_PREFIXES(PredictorTest, BenefitLookupTest);
-  FRIEND_TEST_ALL_PREFIXES(PredictorTest, ShutdownWhenResolutionIsPendingTest);
-  FRIEND_TEST_ALL_PREFIXES(PredictorTest, SingleLookupTest);
-  FRIEND_TEST_ALL_PREFIXES(PredictorTest, ConcurrentLookupTest);
-  FRIEND_TEST_ALL_PREFIXES(PredictorTest, MassiveConcurrentLookupTest);
+  FRIEND_TEST_ALL_PREFIXES(PredictorBrowserTest,
+                           ShutdownWhenResolutionIsPendingTest);
+  FRIEND_TEST_ALL_PREFIXES(PredictorBrowserTest, SingleLookupTest);
+  FRIEND_TEST_ALL_PREFIXES(PredictorBrowserTest, ConcurrentLookupTest);
+  FRIEND_TEST_ALL_PREFIXES(PredictorBrowserTest, MassiveConcurrentLookupTest);
   FRIEND_TEST_ALL_PREFIXES(PredictorTest, PriorityQueuePushPopTest);
   FRIEND_TEST_ALL_PREFIXES(PredictorTest, PriorityQueueReorderTest);
   FRIEND_TEST_ALL_PREFIXES(PredictorTest, ReferrerSerializationTrimTest);
@@ -333,6 +333,7 @@ class Predictor {
   FRIEND_TEST_ALL_PREFIXES(PredictorTest, ProxyDefinitelyNotEnabled);
   FRIEND_TEST_ALL_PREFIXES(PredictorTest, ProxyMaybeEnabled);
   friend class WaitForResolutionHelper;  // For testing.
+  friend class PredictorBrowserTest;

[Randy Smith (Not in Mondays), 2016/05/23 19:55:18]

Usually there's a way, if you friend the test fixture, to not have to friend the
individual tests, by creating methods on the text fixture that reaches into the
friended class.  Did you look into doing that here?

[Charlie Harrison, 2016/05/24 16:57:06]

Yeah I'll do that.

 
   class LookupRequest;