[turbofan] Add FixedArray peephole optimizations to CodeStubAssembler

src/code-stub-assembler.h

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_CODE_STUB_ASSEMBLER_H_
 #define V8_CODE_STUB_ASSEMBLER_H_
 
 #include "src/compiler/code-assembler.h"
 #include "src/objects.h"
 
@@ skipping 14 matching lines @@
   // TODO(rmcilroy): move result_size to the CallInterfaceDescriptor.
   CodeStubAssembler(Isolate* isolate, Zone* zone,
                     const CallInterfaceDescriptor& descriptor,
                     Code::Flags flags, const char* name,
                     size_t result_size = 1);
 
   // Create with JSCall linkage.
   CodeStubAssembler(Isolate* isolate, Zone* zone, int parameter_count,
                     Code::Flags flags, const char* name);
 
+  enum ParameterMode { INTEGER_PARAMETERS, SMI_PARAMETERS };
+
   compiler::Node* BooleanMapConstant();
   compiler::Node* EmptyStringConstant();
   compiler::Node* HeapNumberMapConstant();
   compiler::Node* NoContextConstant();
   compiler::Node* NullConstant();
   compiler::Node* UndefinedConstant();
   compiler::Node* StaleRegisterConstant();
 
   // Float64 operations.
   compiler::Node* Float64Ceil(compiler::Node* x);
@@ skipping 82 matching lines @@
   compiler::Node* LoadMapPrototype(compiler::Node* map);
 
   // Load the hash field of a name.
   compiler::Node* LoadNameHash(compiler::Node* name);
   // Load the instance size of a Map.
   compiler::Node* LoadMapInstanceSize(compiler::Node* map);
 
   compiler::Node* AllocateUninitializedFixedArray(compiler::Node* length);
 
   // Load an array element from a FixedArray.
-  compiler::Node* LoadFixedArrayElementInt32Index(compiler::Node* object,
-                                                  compiler::Node* int32_index,
-                                                  int additional_offset = 0);
-  compiler::Node* LoadFixedArrayElementSmiIndex(compiler::Node* object,
-                                                compiler::Node* smi_index,
-                                                int additional_offset = 0);
-  compiler::Node* LoadFixedArrayElementConstantIndex(compiler::Node* object,
-                                                     int index);
+  compiler::Node* LoadFixedArrayElement(
+      compiler::Node* object, compiler::Node* int32_index,
+      int additional_offset = 0,
+      ParameterMode parameter_mode = INTEGER_PARAMETERS);
 
   // Context manipulation
   compiler::Node* LoadNativeContext(compiler::Node* context);
 
   compiler::Node* LoadJSArrayElementsMap(ElementsKind kind,
                                          compiler::Node* native_context);
 
   // Store the floating point value of a HeapNumber.
   compiler::Node* StoreHeapNumberValue(compiler::Node* object,
                                        compiler::Node* value);
   // Store a field to an object on the heap.
   compiler::Node* StoreObjectField(
       compiler::Node* object, int offset, compiler::Node* value);
   compiler::Node* StoreObjectFieldNoWriteBarrier(
       compiler::Node* object, int offset, compiler::Node* value,
       MachineRepresentation rep = MachineRepresentation::kTagged);
   // Store the Map of an HeapObject.
   compiler::Node* StoreMapNoWriteBarrier(compiler::Node* object,
                                          compiler::Node* map);
   // Store an array element to a FixedArray.
-  compiler::Node* StoreFixedArrayElementInt32Index(compiler::Node* object,
-                                                   compiler::Node* index,
-                                                   compiler::Node* value);
-  compiler::Node* StoreFixedArrayElementNoWriteBarrier(compiler::Node* object,
-                                                       compiler::Node* index,
-                                                       compiler::Node* value);
-  compiler::Node* StoreFixedDoubleArrayElementInt32Index(compiler::Node* object,
-                                                         compiler::Node* index,
-                                                         compiler::Node* value);
-  compiler::Node* StoreFixedArrayElementInt32Index(compiler::Node* object,
-                                                   int index,
-                                                   compiler::Node* value);
-  compiler::Node* StoreFixedArrayElementNoWriteBarrier(compiler::Node* object,
-                                                       int index,
-                                                       compiler::Node* value);
-  compiler::Node* StoreFixedDoubleArrayElementInt32Index(compiler::Node* object,
-                                                         int index,
-                                                         compiler::Node* value);
+  compiler::Node* StoreFixedArrayElement(
+      compiler::Node* object, compiler::Node* index, compiler::Node* value,
+      WriteBarrierMode barrier_mode = UPDATE_WRITE_BARRIER,
+      ParameterMode parameter_mode = INTEGER_PARAMETERS);
+
+  compiler::Node* StoreFixedDoubleArrayElement(
+      compiler::Node* object, compiler::Node* index, compiler::Node* value,
+      ParameterMode parameter_mode = INTEGER_PARAMETERS);
 
   // Allocate a HeapNumber without initializing its value.
   compiler::Node* AllocateHeapNumber();
   // Allocate a HeapNumber with a specific value.
   compiler::Node* AllocateHeapNumberWithValue(compiler::Node* value);
   // Allocate a SeqOneByteString with the given length.
   compiler::Node* AllocateSeqOneByteString(int length);
   // Allocate a SeqTwoByteString with the given length.
   compiler::Node* AllocateSeqTwoByteString(int length);
   // Allocated an JSArray
   compiler::Node* AllocateJSArray(ElementsKind kind, compiler::Node* array_map,
-                                  int capacity, int length,
-                                  compiler::Node* allocation_site = nullptr);
+                                  compiler::Node* capacity,
+                                  compiler::Node* length,
+                                  compiler::Node* allocation_site = nullptr,
+                                  ParameterMode mode = INTEGER_PARAMETERS);
 
   // Allocation site manipulation
   void InitializeAllocationMemento(compiler::Node* base_allocation,
                                    int base_allocation_size,
                                    compiler::Node* allocation_site);
 
   compiler::Node* TruncateTaggedToFloat64(compiler::Node* context,
                                           compiler::Node* value);
   compiler::Node* TruncateTaggedToWord32(compiler::Node* context,
                                          compiler::Node* value);
@@ skipping 41 matching lines @@
                         Label* if_found, Label* if_not_found,
                         Label* call_runtime);
 
   // Instanceof helpers.
   // ES6 section 7.3.19 OrdinaryHasInstance (C, O)
   compiler::Node* OrdinaryHasInstance(compiler::Node* context,
                                       compiler::Node* callable,
                                       compiler::Node* object);
 
  private:
+  compiler::Node* ElementOffsetFromIndex(compiler::Node* index,
+                                         ElementsKind kind, ParameterMode mode,
+                                         int base_size = 0);
+
   compiler::Node* AllocateRawAligned(compiler::Node* size_in_bytes,
                                      AllocationFlags flags,
                                      compiler::Node* top_address,
                                      compiler::Node* limit_address);
   compiler::Node* AllocateRawUnaligned(compiler::Node* size_in_bytes,
                                        AllocationFlags flags,
                                        compiler::Node* top_adddress,
                                        compiler::Node* limit_address);
 
   static const int kElementLoopUnrollThreshold = 8;
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_CODE_STUB_ASSEMBLER_H_