Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989363003: Valgrind: Remove obsolete (and incorrectly) disabled tests. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Valgrind: Remove obsolete (and incorrectly) disabled tests. BUG=7477 Committed: https://crrev.com/8c2395a41dd5939f7917654d23e76892a041a4c9 Cr-Commit-Position: refs/heads/master@{#394614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M tools/valgrind/gtest_exclude/base_unittests.gtest.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-18 23:06:06 UTC) #2
Jeffrey Yasskin
LGTM
4 years, 7 months ago (2016-05-18 23:08:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989363003/1
4 years, 7 months ago (2016-05-18 23:09:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 00:16:51 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 00:19:00 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8c2395a41dd5939f7917654d23e76892a041a4c9
Cr-Commit-Position: refs/heads/master@{#394614}

Powered by Google App Engine
This is Rietveld 408576698