Turn some field trial debug instrumentation into a trial.

Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406
Committed: https://crrev.com/19d105a2a1ec66924ff415f27ff170db7a67ba36
Cr-Commit-Position: refs/heads/master@{#394609}

[Alexei Svitkine (slow), 2016-05-18 15:49:19]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2016-05-18 16:22:50]

Description was changed from

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

BUG=359406
==========

to

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406
==========

[Alexei Svitkine (slow), 2016-05-18 16:24:27]

Patchset #1 (id:20001) has been deleted

[Alexei Svitkine (slow), 2016-05-18 16:24:38]

asvitkine@chromium.org changed reviewers:
+ rkaplow@chromium.org

[rkaplow, 2016-05-18 19:40:45]

lgtm

[Alexei Svitkine (slow), 2016-05-18 19:46:22]

The CQ bit was checked by asvitkine@chromium.org

[commit-bot: I haz the power, 2016-05-18 19:47:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989353002/40001

[commit-bot: I haz the power, 2016-05-18 21:08:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 21:08:49]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexei Svitkine (slow), 2016-05-18 21:35:41]

Patchset #2 (id:60001) has been deleted

[Alexei Svitkine (slow), 2016-05-18 21:36:00]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-05-18 21:36:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org
Link to the patchset: https://codereview.chromium.org/1989353002/#ps80001
(title: "Fix enable benchmarking DCHECK")

[commit-bot: I haz the power, 2016-05-18 21:36:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989353002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989353002/80001

[commit-bot: I haz the power, 2016-05-18 23:58:11]

Description was changed from

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406
==========

to

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406
==========

[commit-bot: I haz the power, 2016-05-18 23:58:12]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-05-19 00:00:49]

Description was changed from

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406
==========

to

==========
Turn some field trial debug instrumentation into a trial.

This is to diagnose what happened with crbug.com/359406,
where we saw the renderer crash disappear coinciding with
me landing https://codereview.chromium.org/1897493002 but
without any corresponding browser crashes appearing.

This change turns that instrumentation to be field-trial
based (50/50), so we can see if the renderer crashes
re-appear for the non-instrumentation group. The trial
is hard-coded because it needs to be initialized early
before variations trials are processed.

Also switching the debug token appending to not be
tied to the other instrumentation.

BUG=359406

Committed: https://crrev.com/19d105a2a1ec66924ff415f27ff170db7a67ba36
Cr-Commit-Position: refs/heads/master@{#394609}
==========

[commit-bot: I haz the power, 2016-05-19 00:00:50]

Patchset 2 (id:??) landed as
https://crrev.com/19d105a2a1ec66924ff415f27ff170db7a67ba36
Cr-Commit-Position: refs/heads/master@{#394609}