third_party/WebKit/Source/core/css/SelectorChecker.cpp - Issue 1989343002: Implement :defined pseudo-class selector for Custom Elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1989343002: Implement :defined pseudo-class selector for Custom Elements (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ce-state

Patch Set: Fix DCHECK Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html ('K') | « third_party/WebKit/Source/core/css/RuleFeature.cpp ('k') | third_party/WebKit/Source/core/dom/Node.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/SelectorChecker.cpp

diff --git a/third_party/WebKit/Source/core/css/SelectorChecker.cpp b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

index 4a45c2d770fb2ec8db58588357bcbe47aa2823ce..be4dc27bc6e06f9287aecb3657ea5b76d30e0e6c 100644

--- a/third_party/WebKit/Source/core/css/SelectorChecker.cpp

+++ b/third_party/WebKit/Source/core/css/SelectorChecker.cpp

@@ -916,6 +916,9 @@ bool SelectorChecker::checkPseudoClass(const SelectorCheckingContext& context, M

return context.scope == &element;

case CSSSelector::PseudoUnresolved:

return element.isUnresolvedV0CustomElement();

+ case CSSSelector::PseudoDefined:

+ DCHECK(RuntimeEnabledFeatures::customElementsV1Enabled());

+ return element.isDefined();

case CSSSelector::PseudoHost:

case CSSSelector::PseudoHostContext:

return checkPseudoHost(context, result);