Implement :defined pseudo-class selector for Custom Elements

Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

Adding use counter is in a separate patch, as it's updated more often
and needs other reviewers.

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918
Committed: https://crrev.com/533a15025f7409bf1d820bb361b4972aa320a43a
Cr-Commit-Position: refs/heads/master@{#396139}

[kojii, 2016-05-20 01:49:47]

Description was changed from

==========
WIP: Implement :defined selector

BUG=
==========

to

==========
WIP: Implement :defined selector

https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=
==========

[kojii, 2016-05-24 02:37:09]

Patchset #4 (id:60001) has been deleted

[kojii, 2016-05-24 02:41:40]

Patchset #4 (id:80001) has been deleted

[kojii, 2016-05-24 03:38:39]

Description was changed from

==========
WIP: Implement :defined selector

https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=
==========

to

==========
Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918
==========

[kojii, 2016-05-24 03:39:50]

Description was changed from

==========
Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918
==========

to

==========
Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

Adding use counter is in a separate patch, as it's updated more often
and needs other reviewers.

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918
==========

[kojii, 2016-05-25 14:43:14]

kojii@chromium.org changed reviewers:
+ timloh@chromium.org

[kojii, 2016-05-25 14:43:15]

PTAL.

[rune, 2016-05-25 23:43:06]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-05-25 23:43:07]

Would also be good to have a test where :defined state changes dynamically on an
element (trigger pseudoStateChanged()).

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html
(right):

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:4:
<div id="log"></div>
Is the #log element necessary?

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:18:
+ `* { color:${neither}; }`
Looks like you're mixing single-quotes and back-ticks. Use single-quotes
consistently?

[kojii, 2016-05-26 01:25:40]

Thank you for your prompt review.

> Would also be good to have a test where :defined state changes dynamically on
an element (trigger pseudoStateChanged()).

Good point. Unfortunately, Custom Elements v1 is still in-progress that it sets
initial state but does not change the state yet.

I'll add tests when the state changes are implemented. Sorry the order of
implementation is a bit confusing.

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html
(right):

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:4:
<div id="log"></div>
On 2016/05/25 at 23:43:07, rune wrote:
> Is the #log element necessary?

Good point. Until recently, our testharnessreport.js does not empty body only
when #log exists, but I remember tkent@ changed that to empty regardless of
#log, so I think this is no longer necessary. I'll remove it.

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:18:
+ `* { color:${neither}; }`
On 2016/05/25 at 23:43:07, rune wrote:
> Looks like you're mixing single-quotes and back-ticks. Use single-quotes
consistently?

Only back-ticks does template literals which I recently learned from a reviewer:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_li...
so I can consistently use back-ticks but not single-quotes.

[kojii, 2016-05-26 04:49:43]

In another CL, dominicc@ pointed out that we should test disconnected documents
too, as defined "If document has a browsing context" in 7.3 of the spec:
https://dom.spec.whatwg.org/#concept-create-element
so the test was added in PS7, along with readability fix rune@ pointed out.

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html
(right):

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:18:
+ `* { color:${neither}; }`
On 2016/05/26 at 01:25:40, kojii wrote:
> On 2016/05/25 at 23:43:07, rune wrote:
> > Looks like you're mixing single-quotes and back-ticks. Use single-quotes
consistently?
> 
> Only back-ticks does template literals which I recently learned from a
reviewer:
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_li...
> so I can consistently use back-ticks but not single-quotes.

I happen to find the back-ticks support new-lines within the literal, it can
make this easier to read. Does this look better?

If you think we should use back-ticks consistently regardless of the use of
templates interpolation, I'm ok with that, please let me know.

[rune, 2016-05-26 07:16:27]

lgtm

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html
(right):

https://codereview.chromium.org/1989343002/diff/140001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/custom-elements/spec/selectors/pseudo-class-defined.html:18:
+ `* { color:${neither}; }`
On 2016/05/26 04:49:43, kojii wrote:
> On 2016/05/26 at 01:25:40, kojii wrote:
> > On 2016/05/25 at 23:43:07, rune wrote:
> > > Looks like you're mixing single-quotes and back-ticks. Use single-quotes
> consistently?
> > 
> > Only back-ticks does template literals which I recently learned from a
> reviewer:
> >
>
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_li...
> > so I can consistently use back-ticks but not single-quotes.
> 
> I happen to find the back-ticks support new-lines within the literal, it can
> make this easier to read. Does this look better?
> 
> If you think we should use back-ticks consistently regardless of the use of
> templates interpolation, I'm ok with that, please let me know.

No looks good now. Excuse my ES6 ignorance. I didn't know back-ticks were
required for the templating.

[kojii, 2016-05-26 07:20:04]

Thank you for the prompt review!

[kojii, 2016-05-26 07:20:08]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-05-26 07:20:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1989343002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1989343002/160001

[commit-bot: I haz the power, 2016-05-26 07:24:11]

Committed patchset #7 (id:160001)

[commit-bot: I haz the power, 2016-05-26 07:26:04]

Description was changed from

==========
Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

Adding use counter is in a separate patch, as it's updated more often
and needs other reviewers.

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918
==========

to

==========
Implement :defined pseudo-class selector for Custom Elements

This patch implements :defined pseudo-class selector[1].

Adding use counter is in a separate patch, as it's updated more often
and needs other reviewers.

[1] https://html.spec.whatwg.org/multipage/scripting.html#selector-defined

BUG=594918

Committed: https://crrev.com/533a15025f7409bf1d820bb361b4972aa320a43a
Cr-Commit-Position: refs/heads/master@{#396139}
==========

[commit-bot: I haz the power, 2016-05-26 07:26:06]

Patchset 7 (id:??) landed as
https://crrev.com/533a15025f7409bf1d820bb361b4972aa320a43a
Cr-Commit-Position: refs/heads/master@{#396139}