Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 1989333003: mash: Rename browser_driver to app_driver. (Closed)

Created:
4 years, 7 months ago by sadrul
Modified:
4 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Rename browser_driver to app_driver. This same app will be responsible for launching apps other than chrome in response to some system accelerator. So give it a more generic name. BUG=none Committed: https://crrev.com/8702c441203a6741c3586c8cf5b5bf43333e86c9 Cr-Commit-Position: refs/heads/master@{#394661}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -334 lines) Patch
M chrome/app/mash/BUILD.gn View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + mash/app_driver/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + mash/app_driver/app_driver.h View 1 3 chunks +11 lines, -11 lines 0 comments Download
A + mash/app_driver/app_driver.cc View 1 6 chunks +17 lines, -24 lines 0 comments Download
A + mash/app_driver/main.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + mash/app_driver/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
D mash/browser_driver/BUILD.gn View 1 chunk +0 lines, -52 lines 0 comments Download
D mash/browser_driver/browser_driver_application_delegate.h View 1 chunk +0 lines, -56 lines 0 comments Download
D mash/browser_driver/browser_driver_application_delegate.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D mash/browser_driver/main.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D mash/browser_driver/manifest.json View 1 chunk +0 lines, -18 lines 0 comments Download
M mash/session/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/session/session.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
sadrul
4 years, 7 months ago (2016-05-19 01:55:07 UTC) #2
Ben Goodger (Google)
lgtm https://codereview.chromium.org/1989333003/diff/1/mash/app_driver/app_driver_application_delegate.h File mash/app_driver/app_driver_application_delegate.h (right): https://codereview.chromium.org/1989333003/diff/1/mash/app_driver/app_driver_application_delegate.h#newcode23 mash/app_driver/app_driver_application_delegate.h:23: class AppDriverApplicationDelegate : public shell::ShellClient, may as well ...
4 years, 7 months ago (2016-05-19 01:59:31 UTC) #3
sadrul
https://codereview.chromium.org/1989333003/diff/1/mash/app_driver/app_driver_application_delegate.h File mash/app_driver/app_driver_application_delegate.h (right): https://codereview.chromium.org/1989333003/diff/1/mash/app_driver/app_driver_application_delegate.h#newcode23 mash/app_driver/app_driver_application_delegate.h:23: class AppDriverApplicationDelegate : public shell::ShellClient, On 2016/05/19 01:59:31, Ben ...
4 years, 7 months ago (2016-05-19 02:18:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989333003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989333003/20001
4 years, 7 months ago (2016-05-19 02:24:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 04:00:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 04:01:54 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8702c441203a6741c3586c8cf5b5bf43333e86c9
Cr-Commit-Position: refs/heads/master@{#394661}

Powered by Google App Engine
This is Rietveld 408576698