Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1989333002: Fix icu_use_data_file = false. (Closed)

Created:
4 years, 7 months ago by altimin
Modified:
4 years, 6 months ago
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix icu_use_data_file = false. - Move variables needed only with ICU_UTIL_DATA_IMPL == ICU_UTIL_DATA_FILE inside corresponding ifdef. - Move ICU_UTIL_DATA_* defines to header. - Hide calls to base::i18n::InitializeICUFromRawMemory and base::i18n::GetRawIcuMemory in services/shell/ under ifdef. R=jshin@chromium.org, CC=alexclarke@chromium.org,skyostil@chromium.org BUG=610673 Committed: https://crrev.com/3b1f5303df713c0879ef425e19bd75229c32ef45 Cr-Commit-Position: refs/heads/master@{#394750}

Patch Set 1 #

Patch Set 2 : Update DEPS for ICU. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/icu_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M base/i18n/icu_util.cc View 3 chunks +2 lines, -6 lines 0 comments Download
M services/shell/public/cpp/lib/initialize_base_and_icu.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M services/shell/runner/init.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
altimin
4 years, 7 months ago (2016-05-18 16:05:23 UTC) #3
Ken Rockot(use gerrit already)
rs lgtm
4 years, 7 months ago (2016-05-18 16:08:28 UTC) #4
jungshik at Google
LGTM
4 years, 7 months ago (2016-05-18 21:15:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989333002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989333002/20001
4 years, 7 months ago (2016-05-19 10:45:42 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 12:34:34 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 12:36:47 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3b1f5303df713c0879ef425e19bd75229c32ef45
Cr-Commit-Position: refs/heads/master@{#394750}

Powered by Google App Engine
This is Rietveld 408576698