Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 198923010: Retry r259150: Determine language code and type of format for address. (Closed)

Created:
6 years, 9 months ago by please use gerrit instead
Modified:
6 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

Retry r259150: Determine language code and type of format for address. BuildComponents() in address_ui.h should take the UI language and determine the following two questions. (1) Whether to show UI components based on local or latinized address format. If the UI language does not match the default language for the country, and latinized address format is available, then use the latinized format. All countries with a latinized address format also have the default language specified. (2) Which language code should be used to format the address after the user provides it. If the UI language is one of the languages supported by the country, then use the UI language. If the country lists supported languages, none of which match the UI language, then pick the first supported language. If the country does not have supported languages (e.g. Antarctica), then use the UI language for formatting. If using the latinized format and the UI language is not one of the supported languages, then the formatting language is [country's default language] + "-latn". BUG=354954 Originally landed: http://crrev.com/259150 Reverted: http://crrev.com/259239 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259606

Patch Set 1 #

Patch Set 2 : Fix build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+684 lines, -402 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_i18n_input.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/country_combobox_model_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_data.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/include/libaddressinput/address_ui.h View 1 chunk +20 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_data.cc View 3 chunks +11 lines, -24 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_ui.cc View 5 chunks +92 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/address_validator.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/region_data_constants.cc View 24 chunks +298 lines, -55 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/retriever.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/rule.h View 3 chunks +14 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/rule.cc View 5 chunks +13 lines, -2 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/time_to_string.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/time_to_string.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_compare.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_compare.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_split.h View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/util/string_split.cc View 1 chunk +0 lines, -37 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_util.h View 1 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/libaddressinput/chromium/cpp/src/util/string_util.cc View 1 chunk +80 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_data_test.cc View 2 chunks +28 lines, -0 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/address_ui_test.cc View 3 chunks +51 lines, -2 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/countryinfo_example_addresses_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/retriever_test.cc View 1 chunk +1 line, -1 line 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/util/string_split_unittest.cc View 1 chunk +0 lines, -89 lines 0 comments Download
A + third_party/libaddressinput/chromium/cpp/test/util/string_util_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
please use gerrit instead
Evan: PTAL Patch Set 2.
6 years, 9 months ago (2014-03-25 21:04:33 UTC) #1
Evan Stade
lgtm
6 years, 9 months ago (2014-03-25 22:41:15 UTC) #2
Evan Stade
however the first line of the description should be something like: Retry r259150: [...]
6 years, 9 months ago (2014-03-25 22:41:43 UTC) #3
please use gerrit instead
On 2014/03/25 22:41:43, Evan Stade wrote: > however the first line of the description should ...
6 years, 9 months ago (2014-03-25 22:50:15 UTC) #4
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 9 months ago (2014-03-25 22:50:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/198923010/30001
6 years, 9 months ago (2014-03-25 22:52:02 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-26 01:16:31 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=287978
6 years, 9 months ago (2014-03-26 01:16:31 UTC) #8
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 9 months ago (2014-03-26 16:50:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/198923010/30001
6 years, 9 months ago (2014-03-26 16:50:49 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-03-26 16:52:19 UTC) #11
Message was sent while issue was closed.
Change committed as 259606

Powered by Google App Engine
This is Rietveld 408576698