xfa/fwl/basewidget/fwl_editimp.cpp - Issue 1989203007: Work around sign compare error from commit be9b894.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fwl/basewidget/fwl_editimp.cpp

Issue 1989203007: Work around sign compare error from commit be9b894. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fwl/basewidget/fwl_editimp.cpp

diff --git a/xfa/fwl/basewidget/fwl_editimp.cpp b/xfa/fwl/basewidget/fwl_editimp.cpp

index b734ec6e77bc302beb8fdd4e4c3100083ec63b3b..1aa97a10c1cf89225d15d20ccb84f3677d8cd999 100644

--- a/xfa/fwl/basewidget/fwl_editimp.cpp

+++ b/xfa/fwl/basewidget/fwl_editimp.cpp

@@ -779,7 +779,8 @@ FX_BOOL CFWL_EditImp::CanUndo() {

}

FX_BOOL CFWL_EditImp::CanRedo() {

- return m_iCurRecord < m_DoRecords.size() - 1;

+ int32_t nCount = m_DoRecords.size();

+ return m_iCurRecord < nCount - 1;

Tom Sepez 2016/05/20 00:09:19 nit: return m_iCurRecord < pdfium::CollectionSiz

}

FWL_Error CFWL_EditImp::SetTabWidth(FX_FLOAT fTabWidth, FX_BOOL bEquidistant) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »