Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1989203007: Work around sign compare error from commit be9b894. (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com, dsinclair
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Work around sign compare error from commit be9b894. Committed: https://pdfium.googlesource.com/pdfium/+/8b45eb1443e5a31f6f172fa16169b9b56177b639

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M xfa/fwl/basewidget/fwl_editimp.cpp View 1 4 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Lei Zhang
sigh
4 years, 7 months ago (2016-05-19 23:53:56 UTC) #2
Tom Sepez
lgtm https://codereview.chromium.org/1989203007/diff/1/xfa/fwl/basewidget/fwl_editimp.cpp File xfa/fwl/basewidget/fwl_editimp.cpp (right): https://codereview.chromium.org/1989203007/diff/1/xfa/fwl/basewidget/fwl_editimp.cpp#newcode783 xfa/fwl/basewidget/fwl_editimp.cpp:783: return m_iCurRecord < nCount - 1; nit: return ...
4 years, 7 months ago (2016-05-20 00:09:19 UTC) #3
Lei Zhang
On 2016/05/20 00:09:19, Tom Sepez wrote: > return m_iCurRecord < pdfium::CollectionSize<int>(m_DoRecords); I changed a couple ...
4 years, 7 months ago (2016-05-20 00:14:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989203007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989203007/20001
4 years, 7 months ago (2016-05-20 01:34:47 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 01:35:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8b45eb1443e5a31f6f172fa16169b9b56177...

Powered by Google App Engine
This is Rietveld 408576698