Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989203004: [serializer] fix deserializing cell targets in code. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] fix deserializing cell targets in code. R=mtrofin@chromium.org Committed: https://crrev.com/806739279a00a546dff8211abb08163a03299971 Cr-Commit-Position: refs/heads/master@{#36363}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -5 lines) Patch
M src/snapshot/deserializer.cc View 3 chunks +11 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +50 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 7 months ago (2016-05-19 12:25:17 UTC) #1
Mircea Trofin
lgtm
4 years, 7 months ago (2016-05-19 12:32:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989203004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989203004/1
4 years, 7 months ago (2016-05-19 12:34:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 13:09:11 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 13:10:29 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/806739279a00a546dff8211abb08163a03299971
Cr-Commit-Position: refs/heads/master@{#36363}

Powered by Google App Engine
This is Rietveld 408576698