Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1060)

Issue 1989203003: Update checks for N+ (Closed)

Created:
4 years, 7 months ago by Theresa
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, mikecase+watch_chromium.org, android-webview-reviews_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update checks for N+ Replace checks for Build.VERSION.CODENAME.equals("N") wieth Build.VERSION.CODENAMES.equals("N") || Build.VERSION.SDK_INT > Build.VERSION_CODES.M. Eventually we will want the check to be just for SDK_INT, but for M51 we'll use the ||. BUG=586703 Committed: https://crrev.com/96a31a443985b11f125797d32f837eff42f2efb3 Cr-Commit-Position: refs/heads/master@{#394615}

Patch Set 1 #

Messages

Total messages: 10 (3 generated)
Theresa
techoc@ - ptal at chrome/android/java/* sgurun@ - ptal at android_webview/ agrieve@ - ptal at build/ ...
4 years, 7 months ago (2016-05-18 23:00:05 UTC) #2
Ted C
lgtm
4 years, 7 months ago (2016-05-18 23:29:50 UTC) #3
sgurun-gerrit only
On 2016/05/18 23:29:50, Ted C wrote: > lgtm lgtm
4 years, 7 months ago (2016-05-18 23:52:33 UTC) #4
agrieve
On 2016/05/18 23:52:33, sgurun wrote: > On 2016/05/18 23:29:50, Ted C wrote: > > lgtm ...
4 years, 7 months ago (2016-05-19 00:11:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989203003/1
4 years, 7 months ago (2016-05-19 00:13:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 00:18:28 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 00:21:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/96a31a443985b11f125797d32f837eff42f2efb3
Cr-Commit-Position: refs/heads/master@{#394615}

Powered by Google App Engine
This is Rietveld 408576698