[gn] Make gyp include dirs equal to gn

src/v8.gyp

 # Copyright 2012 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 #       copyright notice, this list of conditions and the following
 #       disclaimer in the documentation and/or other materials provided
@@ skipping 1891 matching lines @@
       'target_name': 'v8_libplatform',
       'type': 'static_library',
       'variables': {
         'optimize': 'max',
       },
       'dependencies': [
         'v8_libbase',
       ],
       'include_dirs+': [
         '..',
+        '../include',

[Michael Achenbach, 2016/05/18 10:40:41]

This accounts for a semantic difference between public configs in gn and
direct_dependent_settings in gyp.

See description of direct_dependent_settings in gyp:
https://gyp.gsrc.io/docs/UserDocumentation.md#Skeleton-of-a-typical-library-t...

See description of public configs in gn:
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/referen...

GN includes configs also on the target itself, while in gyp, configs are applied
to the dependent targets only.

In gn, the include dir is in the public configs of libplatform:
https://code.google.com/p/chromium/codesearch#chromium/src/v8/BUILD.gn&l=115

While in gyp it's in direct_dependent_settings. See line 1930.

This change won't have a visible effect on compilation, but it will silence a
lot of differences in the gyp/gn diff tool.

       ],
       'sources': [
         '../include/libplatform/libplatform.h',
         'libplatform/default-platform.cc',
         'libplatform/default-platform.h',
         'libplatform/task-queue.cc',
         'libplatform/task-queue.h',
         'libplatform/worker-thread.cc',
         'libplatform/worker-thread.h',
       ],
@@ skipping 317 matching lines @@
         }],
         ['want_separate_host_toolset==1', {
           'toolsets': ['host'],
         }, {
           'toolsets': ['target'],
         }],
       ],
     },
   ],
 }