[Autofill] Dedupe similar profiles on insertion.

components/autofill/core/browser/personal_data_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_
 
 #include <memory>
 #include <set>
 #include <vector>
@@ skipping 196 matching lines @@
   const std::string& app_locale() const { return app_locale_; }
 
   // Checks suitability of |profile| for adding to the user's set of profiles.
   static bool IsValidLearnableProfile(const AutofillProfile& profile,
                                       const std::string& app_locale);
 
   // Merges |new_profile| into one of the |existing_profiles| if possible;
   // otherwise appends |new_profile| to the end of that list. Fills
   // |merged_profiles| with the result. Returns the |guid| of the new or updated
   // profile.
-  static std::string MergeProfile(
-      const AutofillProfile& new_profile,
-      std::vector<AutofillProfile*> existing_profiles,
-      const std::string& app_locale,
-      std::vector<AutofillProfile>* merged_profiles);
+  std::string MergeProfile(const AutofillProfile& new_profile,
+                           std::vector<AutofillProfile*> existing_profiles,
+                           const std::string& app_locale,
+                           std::vector<AutofillProfile>* merged_profiles);
 
   // Returns true if |country_code| is a country that the user is likely to
   // be associated with the user. More concretely, it checks if there are any
   // addresses with this country or if the user's system timezone is in the
   // given country.
   virtual bool IsCountryOfInterest(const std::string& country_code) const;
 
   // Returns our best guess for the country a user is likely to use when
   // inputting a new address. The value is calculated once and cached, so it
   // will only update when Chrome is restarted.
   virtual const std::string& GetDefaultCountryCodeForNewAddress() const;
 
   // De-dupe credit card to suggest. Full server cards are prefered over their
   // local duplicates, and local cards are preferred over their masked server
   // card duplicate.
   static void DedupeCreditCardToSuggest(
       std::list<const CreditCard*>* cards_to_suggest);
 
  protected:
   // Only PersonalDataManagerFactory and certain tests can create instances of
   // PersonalDataManager.
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, FirstMiddleLast);
   FRIEND_TEST_ALL_PREFIXES(AutofillMetricsTest, AutofillIsEnabledAtStartup);
+  FRIEND_TEST_ALL_PREFIXES(PersonalDataManagerTest,
+                           FindAndMergeDuplicateProfiles_ProfilesToDelete);
+  FRIEND_TEST_ALL_PREFIXES(PersonalDataManagerTest,
+                           FindAndMergeDuplicateProfiles_MergedProfileValues);
   friend class autofill::AutofillInteractiveTest;
   friend class autofill::AutofillTest;
   friend class autofill::PersonalDataManagerFactory;
   friend class PersonalDataManagerTest;
 #if defined(OS_IOS)
   // TODO(crbug.com/513344): Remove this once Chrome on iOS is unforked.
   friend class ::PersonalDataManagerFactory;
 #endif
   friend class ProfileSyncServiceAutofillTest;
   friend class ::RemoveAutofillTester;
@@ skipping 135 matching lines @@
   const std::vector<AutofillProfile*>& GetProfiles(
       bool record_metrics) const;
 
   // Returns credit card suggestions based on the |cards_to_suggest| and the
   // |type| and |field_contents| of the credit card field.
   std::vector<Suggestion> GetSuggestionsForCards(
       const AutofillType& type,
       const base::string16& field_contents,
       const std::list<const CreditCard*>& cards_to_suggest) const;
 
+  // Goes through the |existing_profiles| to find similar profiles to
+  // |profile_to_merge|. If a similar profile is found |profile_to_merge| is
+  // merged into it, gets deleted and the result becomes the new
+  // |profile_to_merge|. The process continues until the end of
+  // |existing_profiles| is reached.
+  //
+  // |existing_profiles| should be sorted by frecency to ensure that the more
+  // relevant profiles get merged into the less relevant ones.
+  void FindMergeAndDeleteDuplicateProfiles(
+      const std::vector<AutofillProfile*>& existing_profiles,
+      AutofillProfile* profile_to_merge,
+      const std::string& app_locale);
+
+  // Goes through the |existing_profiles| to find similar profiles to
+  // |profile_to_merge|. If a similar profile is found |profile_to_merge| is
+  // merged into it, its GUID gets added to |profile_guids_to_delete| and the
+  // result becomes the new |profile_to_merge|. The process continues until the
+  // end of |existing_profiles| is reached.
+  void FindAndMergeDuplicateProfiles(

[Roger McFarlane (Chromium), 2016/06/08 18:55:38]

a comment that this is exposed for testability.

[sebsg, 2016/06/08 21:58:46]

Done.

+      const std::vector<AutofillProfile*>& existing_profiles,
+      AutofillProfile* profile_to_merge,
+      std::vector<std::string>* profile_guids_to_delete,
+      const std::string& app_locale);
+
   const std::string app_locale_;
 
   // The default country code for new addresses.
   mutable std::string default_country_code_;
 
   // The PrefService that this instance uses. Must outlive this instance.
   PrefService* pref_service_;
 
   // The AccountTrackerService that this instance uses. Must outlive this
   // instance.
@@ skipping 18 matching lines @@
 
   // An observer to listen for changes to prefs::kAutofillWalletImportEnabled.
   std::unique_ptr<BooleanPrefMember> wallet_enabled_pref_;
 
   DISALLOW_COPY_AND_ASSIGN(PersonalDataManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_PERSONAL_DATA_MANAGER_H_