[Autofill] Dedupe similar profiles on insertion.

components/autofill/core/browser/autofill_profile_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_profile.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 1245 matching lines @@
 
   // The first, middle and last names should be kept and name full should be
   // added.
   EXPECT_EQ(base::ASCIIToUTF16("Marion"), a.GetRawInfo(NAME_FIRST));
   EXPECT_EQ(base::ASCIIToUTF16("Mitchell"), a.GetRawInfo(NAME_MIDDLE));
   EXPECT_EQ(base::ASCIIToUTF16("Morrison"), a.GetRawInfo(NAME_LAST));
   EXPECT_EQ(base::ASCIIToUTF16("Marion Mitchell Morrison"),
             a.GetRawInfo(NAME_FULL));
 }
 
+// Tests that PrimaryValue returns a string containing the first name, last
+// name, first address line and city of the profile with a whitespace in between
+// each part.
+TEST(AutofillProfileTest, PrimaryValue) {

[Mathieu, 2016/06/08 18:32:24]

This test is mostly testing JoinString, and it's not really useful. Would prefer
amending the tests for functions where PrimaryValue is used.

[sebsg, 2016/06/08 21:58:46]

You are right, it was not very useful. I added a test for the case that
initially made me change the PrimaryValue() code to fix a bug.

+  AutofillProfile profile(base::GenerateGUID(), "https://www.example.com/");
+  test::SetProfileInfo(&profile, "Marion", "Mitchell", "Morrison",
+                       "marion@me.xyz", "Fox", "123 Zoo St.", "unit 5",
+                       "Hollywood", "CA", "91601", "US", "12345678910");
+
+  EXPECT_EQ(base::UTF8ToUTF16("Marion Morrison 123 Zoo St. Hollywood"),
+            profile.PrimaryValue());
+}
+
 }  // namespace autofill