Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1989153003: Limit WTF::getPtr() to native pointer types. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Limit WTF::getPtr() to native pointer types. Remove Member<> and Persistent<> specializations, the generated bindings code (only real user of getPtr()) use it to coerce references into pointers only, nothing else. R=haraken BUG= Committed: https://crrev.com/a7ca31c6e5628d16dc4b04a048c48035b01e32b0 Cr-Commit-Position: refs/heads/master@{#394371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M third_party/WebKit/Source/platform/heap/Handle.h View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-18 08:18:22 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-18 08:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989153003/1
4 years, 7 months ago (2016-05-18 08:26:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 09:30:37 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 09:32:36 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7ca31c6e5628d16dc4b04a048c48035b01e32b0
Cr-Commit-Position: refs/heads/master@{#394371}

Powered by Google App Engine
This is Rietveld 408576698