Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1989153002: X87: Fix %FunctionGetName and %_ClassOf for bound functions. (Closed)

Created:
4 years, 7 months ago by zhengxing.li
Modified:
4 years, 7 months ago
Reviewers:
Weiliang, chunyang.dai, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Fix %FunctionGetName and %_ClassOf for bound functions. port 8e303dd0b3d5ded8c91f5982bc565c2edd8c511b (r36276) original commit message: BUG= Committed: https://crrev.com/dcc283e82368309aeed5bb9f3b5228c13d7c39f7 Cr-Commit-Position: refs/heads/master@{#36305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/crankshaft/x87/lithium-codegen-x87.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 7 months ago (2016-05-18 05:53:06 UTC) #2
Weiliang
lgtm
4 years, 7 months ago (2016-05-18 06:26:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989153002/1
4 years, 7 months ago (2016-05-18 06:27:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 06:58:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 06:58:25 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dcc283e82368309aeed5bb9f3b5228c13d7c39f7
Cr-Commit-Position: refs/heads/master@{#36305}

Powered by Google App Engine
This is Rietveld 408576698