Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ui/views/controls/textfield/textfield_model.cc

Issue 1989143002: MacViews: Correct behavior of move and select commands when selection direction changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_commands
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_model.cc
diff --git a/ui/views/controls/textfield/textfield_model.cc b/ui/views/controls/textfield/textfield_model.cc
index d5bec8b33248d549600280d137186bbcf8557850..4704027d8c703ae12ee7f9d6b939d8960cf4cd17 100644
--- a/ui/views/controls/textfield/textfield_model.cc
+++ b/ui/views/controls/textfield/textfield_model.cc
@@ -370,12 +370,14 @@ size_t TextfieldModel::GetCursorPosition() const {
return render_text_->cursor_position();
}
-void TextfieldModel::MoveCursor(gfx::BreakType break_type,
- gfx::VisualCursorDirection direction,
- bool select) {
+void TextfieldModel::MoveCursor(
+ gfx::BreakType break_type,
+ gfx::VisualCursorDirection direction,
+ bool select,
+ gfx::SelectionReversedBehavior select_behavior) {
if (HasCompositionText())
ConfirmCompositionText();
- render_text_->MoveCursor(break_type, direction, select);
+ render_text_->MoveCursor(break_type, direction, select, select_behavior);
}
bool TextfieldModel::MoveCursorTo(const gfx::SelectionModel& cursor) {

Powered by Google App Engine
This is Rietveld 408576698