Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: ui/views/controls/textfield/textfield_model.h

Issue 1989143002: MacViews: Correct behavior of move and select commands when selection direction changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_commands
Patch Set: Address review comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/textfield/textfield_model.h
diff --git a/ui/views/controls/textfield/textfield_model.h b/ui/views/controls/textfield/textfield_model.h
index 135524e289a44035be219830cdb0e1044f7febf1..5f4ddaf711f41ae6665dbc65a98229d893e7cc57 100644
--- a/ui/views/controls/textfield/textfield_model.h
+++ b/ui/views/controls/textfield/textfield_model.h
@@ -114,7 +114,14 @@ class VIEWS_EXPORT TextfieldModel {
// The current composition text will be confirmed.
void MoveCursor(gfx::BreakType break_type,
gfx::VisualCursorDirection direction,
- bool select);
+ bool select,
+ gfx::SelectionReversedBehavior select_behavior);
+
+ void MoveCursor(gfx::BreakType break_type,
+ gfx::VisualCursorDirection direction,
+ bool select) {
+ MoveCursor(break_type, direction, select, gfx::SELECTION_DEFAULT);
+ }
// Updates the cursor to the specified selection model. Any composition text
// will be confirmed, which may alter the specified selection range start.

Powered by Google App Engine
This is Rietveld 408576698