Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: components/test_runner/test_runner.cc

Issue 1989103007: Test for form submission targeting remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing unnecessary logging statements. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/test_runner/test_runner.cc
diff --git a/components/test_runner/test_runner.cc b/components/test_runner/test_runner.cc
index 1a6aa90e4561740cd7beba026cc70f6f4ad1b3d5..2dfd1b318d990371f1808d2e21480cc9f96a80b1 100644
--- a/components/test_runner/test_runner.cc
+++ b/components/test_runner/test_runner.cc
@@ -1927,13 +1927,6 @@ class WorkItemBackForward : public TestRunner::WorkItem {
int distance_;
};
-void TestRunner::NotifyDone() {
- // Test didn't timeout. Kill the pending callbacks.
- weak_factory_.InvalidateWeakPtrs();
-
- CompleteNotifyDone();
-}
-
void TestRunner::WaitUntilDone() {
layout_test_runtime_flags_.set_wait_until_done(true);
OnLayoutTestRuntimeFlagsChanged();
@@ -2716,7 +2709,7 @@ void TestRunner::CheckResponseMimeType() {
OnLayoutTestRuntimeFlagsChanged();
}
-void TestRunner::CompleteNotifyDone() {
+void TestRunner::NotifyDone() {
if (layout_test_runtime_flags_.wait_until_done() && !topLoadingFrame() &&
work_queue_.is_empty())
delegate_->TestFinished();
« no previous file with comments | « components/test_runner/test_runner.h ('k') | third_party/WebKit/LayoutTests/FlagExpectations/site-per-process » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698