third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame.html - Issue 1989103007: Test for form submission targeting remote frame.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame.html

Issue 1989103007: Test for form submission targeting remote frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Test comments + cleaning up the code a bit. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/FlagExpectations/site-per-process ('k') | third_party/WebKit/LayoutTests/http/tests/navigation/form-targets-cross-site-frame-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <!--

	3 The test verifies that a form with target="crossSiteFrame" works fine

	4 (especially in presence of out-of-process-iframes, aka OOPIFs, aka

	5 blink::RemoteFrames which are present in --site-per-process mode).

	6

	7 The test finishes successfully, if form-target.pl ends up calling

	8 testRunner.notifyDone() after main frame calls testRuner.waitUntilDone

	9 and submits the form. Expected test output helps verify that the

	10 correct HTTP method was used and that test field's value from the form

	11 was propagated correctly.

	12 -->

	13 <html>

	14 <script>

	15 if (window.testRunner) {

	16 testRunner.dumpAsText();

	17 testRunner.dumpChildFramesAsText();

	18 }

	19

	20 function onLoad() {

	21 if (window.testRunner) {

	22 testRunner.logToStderr("Caling waitUntilDone");
	alexmos 2016/05/25 17:59:43 nit: s/Caling/Calling/, but are the stderr logs ev nit: s/Caling/Calling/, but are the stderr logs even necessary here and below? Łukasz Anforowicz 2016/05/25 21:31:43 I've removed the logging statements. Show quoted text On 2016/05/25 17:59:43, alexmos wrote: > nit: s/Caling/Calling/, but are the stderr logs even necessary here and below? I've removed the logging statements.
	23 testRunner.waitUntilDone();

	24 }

	25 document.forms[0].submit();

	26 testRunner.logToStderr("Submitting the form");

	27 }

	28 </script>

	29 <body onload="onLoad();">

	30 <form

	31 method="POST"

	32 action="https://localhost:8443/navigation/resources/form-target.pl"

	33 target="cross-site-frame">

	34 Test field:

	35 <input name="test-field" type="text" value="test-value">

	36 <input type="submit" value="Submit">

	37 </form>

	38 <iframe

	39 name="cross-site-frame"

	40 src="https://localhost:8443/navigation/resources/form-target.pl"></iframe>

	41 </body>

	42 </html>

OLD	NEW