components/test_runner/web_frame_test_client.cc - Issue 1989103006: Fix event warning crash when a listener is removed while dispatching event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_frame_test_client.cc

Issue 1989103006: Fix event warning crash when a listener is removed while dispatching event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: now compare against actual listener() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/test_runner.cc ('k') | third_party/WebKit/LayoutTests/inspector/input-event-warning.html » ('j') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_frame_test_client.cc

diff --git a/components/test_runner/web_frame_test_client.cc b/components/test_runner/web_frame_test_client.cc

index 0453c995b04a9defc8890bc688cf947b85db4a9d..54fe96cf4faccaae73e86bd9adddfdc1e19a02f6 100644

--- a/components/test_runner/web_frame_test_client.cc

+++ b/components/test_runner/web_frame_test_client.cc

@@ -663,6 +663,8 @@ void WebFrameTestClient::didAddMessageToConsole(

const blink::WebString& source_name,

unsigned source_line,

const blink::WebString& stack_trace) {

+ if (!test_runner_->ShouldDumpConsoleMessages())

+ return;

std::string level;

switch (message.level) {

case blink::WebConsoleMessage::LevelDebug: