components/test_runner/test_runner.h - Issue 1989103006: Fix event warning crash when a listener is removed while dispatching event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 1989103006: Fix event warning crash when a listener is removed while dispatching event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/layout_test_runtime_flags.cc ('k') | components/test_runner/test_runner.cc » ('j') | third_party/WebKit/Source/core/events/EventTarget.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index 91d88b6ddd321e3631c945fbd3ae068cbbcdc54c..8740476d17588e42f63010953be2f464a3b83cc6 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -161,6 +161,8 @@ class TestRunner : public WebTestRunner {

void DidOpenChooser();

void DidCloseChooser();

+ bool ShouldDumpConsoleMessages() const;

// A single item in the work queue.

class WorkItem {

public:

@@ -451,6 +453,10 @@ class TestRunner : public WebTestRunner {

// policy passed to the decidePolicyForNavigation callback.

void DumpNavigationPolicy();

+ // Controls whether console messages produced by the page are dumped

+ // to test output.

+ void SetDumpConsoleMessages(bool value);

///////////////////////////////////////////////////////////////////////////

// Methods interacting with the WebTestProxy