Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1989083003: Reserve more RAM per Gold process. (Closed)

Created:
4 years, 7 months ago by krasin
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, pcc1, kcc2
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reserve more RAM per Gold process. The current settings are too agressive even given the fact that all the bots have 200+ GB RAM, and there's not so many large targets. OOMs were observed: https://build.chromium.org/p/chromium.fyi/builders/LTO%20Linux/builds/500 BUG=453195 Committed: https://crrev.com/b1e7d762e134b94196f551667ed31535b701e76e Cr-Commit-Position: refs/heads/master@{#394423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/toolchain/get_concurrent_links.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
krasin
4 years, 7 months ago (2016-05-18 03:49:35 UTC) #2
Nico
lgtm
4 years, 7 months ago (2016-05-18 11:57:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989083003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989083003/1
4 years, 7 months ago (2016-05-18 14:08:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 15:17:47 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 15:19:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1e7d762e134b94196f551667ed31535b701e76e
Cr-Commit-Position: refs/heads/master@{#394423}

Powered by Google App Engine
This is Rietveld 408576698