Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1989073002: Remove unnecessary WebappInfo#copy() (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary WebappInfo#copy() WebappInfo#copy() is no longer needed since https://chrome-internal-review.googlesource.com/#/c/193001/ BUG=609122 Committed: https://crrev.com/d5735a022a03d7b28b56fb115c65230655462d79 Cr-Commit-Position: refs/heads/master@{#394627}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -45 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappUrlBarTest.java View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappVisibilityTest.java View 4 chunks +16 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
pkotwicz
dfalcantara@ can you please take a look? This CL is tangentially helpful to WebAPKs
4 years, 7 months ago (2016-05-18 02:32:29 UTC) #4
gone
lgtm, but can you double-check that no one caches the WebappInfo, then add a comment ...
4 years, 7 months ago (2016-05-18 19:10:00 UTC) #5
pkotwicz
I double checked that no one caches in WebappInfo and I added a comment
4 years, 7 months ago (2016-05-18 23:51:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989073002/20001
4 years, 7 months ago (2016-05-18 23:52:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 01:15:59 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 01:17:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d5735a022a03d7b28b56fb115c65230655462d79
Cr-Commit-Position: refs/heads/master@{#394627}

Powered by Google App Engine
This is Rietveld 408576698