Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 198903002: Only call to LogSymbol when needed. (Closed)

Created:
6 years, 9 months ago by dcarney
Modified:
6 years, 9 months ago
Reviewers:
marja
CC:
v8-dev
Visibility:
Public.

Description

Only call to LogSymbol when needed. R=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19892

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -262 lines) Patch
M src/parser.cc View 1 1 chunk +0 lines, -93 lines 0 comments Download
M src/preparse-data.h View 1 2 4 chunks +116 lines, -117 lines 0 comments Download
M src/preparse-data.cc View 1 2 4 chunks +48 lines, -36 lines 0 comments Download
M src/preparser.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M test/cctest/test-parsing.cc View 4 chunks +27 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
marja
lgtm
6 years, 9 months ago (2014-03-13 11:55:09 UTC) #1
dcarney
6 years, 9 months ago (2014-03-13 11:56:20 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 manually as r19892 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698