Chromium Code Reviews
Help | Chromium Project | Sign in
(619)

Issue 1989014: Create a dedicated cache thread and use it to create the... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by rvargas
Modified:
2 years, 10 months ago
Reviewers:
jam
CC:
chromium-reviews_chromium.org, cbentzel+watch_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Create a dedicated cache thread and use it to create the
Http cache.

BUG=26730
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47564

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : use MessageLoopProxy #

Total comments: 2

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -14 lines) Lint Patch
M chrome/browser/browser_main.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/browser/browser_process.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/browser_process_impl.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/browser_process_impl.cc View 1 2 3 3 chunks +17 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/chrome_thread.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments 0 errors Download
M chrome/browser/chrome_thread.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments 0 errors Download
M chrome/test/testing_browser_process.h View 2 3 1 chunk +4 lines, -0 lines 0 comments 0 errors Download
M net/disk_cache/backend_impl.cc View 1 chunk +2 lines, -2 lines 0 comments 0 errors Download
M net/disk_cache/disk_cache.h View 2 chunks +6 lines, -3 lines 0 comments 0 errors Download
M net/http/http_cache.h View 4 4 chunks +3 lines, -3 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 10
rvargas
3 years, 11 months ago #1
jam
http://codereview.chromium.org/1989014/diff/17001/18007 File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/1989014/diff/17001/18007#newcode228 chrome/browser/net/chrome_url_request_context.cc:228: MessageLoop* cache_thread_; why cache it in these places instead ...
3 years, 11 months ago #2
rvargas
http://codereview.chromium.org/1989014/diff/17001/18007 File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/1989014/diff/17001/18007#newcode228 chrome/browser/net/chrome_url_request_context.cc:228: MessageLoop* cache_thread_; On 2010/05/13 18:18:31, John Abd-El-Malek wrote: > ...
3 years, 11 months ago #3
jam
http://codereview.chromium.org/1989014/diff/17001/18007 File chrome/browser/net/chrome_url_request_context.cc (right): http://codereview.chromium.org/1989014/diff/17001/18007#newcode228 chrome/browser/net/chrome_url_request_context.cc:228: MessageLoop* cache_thread_; On 2010/05/13 19:36:54, rvargas wrote: > On ...
3 years, 11 months ago #4
rvargas
On 2010/05/13 19:50:44, John Abd-El-Malek wrote: > http://codereview.chromium.org/1989014/diff/17001/18007 > File chrome/browser/net/chrome_url_request_context.cc (right): > > http://codereview.chromium.org/1989014/diff/17001/18007#newcode228 ...
3 years, 11 months ago #5
jam
On Mon, May 17, 2010 at 3:06 PM, <rvargas@chromium.org> wrote: > On 2010/05/13 19:50:44, John ...
3 years, 11 months ago #6
rvargas
Please take another look. Thanks.
3 years, 11 months ago #7
jam
http://codereview.chromium.org/1989014/diff/33001/34011 File net/http/http_cache.h (right): http://codereview.chromium.org/1989014/diff/33001/34011#newcode111 net/http/http_cache.h:111: base::MessageLoopProxy* thread_; I think this needs to be an ...
3 years, 11 months ago #8
rvargas
thanks. http://codereview.chromium.org/1989014/diff/33001/34011 File net/http/http_cache.h (right): http://codereview.chromium.org/1989014/diff/33001/34011#newcode111 net/http/http_cache.h:111: base::MessageLoopProxy* thread_; On 2010/05/18 17:27:23, John Abd-El-Malek wrote: ...
3 years, 11 months ago #9
jam
3 years, 11 months ago #10
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6