Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2117)

Unified Diff: net/cert/x509_certificate_unittest.cc

Issue 1988993002: Check self-signed certificate names and signatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove dependency on openssl -text format Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/x509_certificate_openssl.cc ('k') | net/cert/x509_certificate_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate_unittest.cc
diff --git a/net/cert/x509_certificate_unittest.cc b/net/cert/x509_certificate_unittest.cc
index 6e35cdaf37fa55a5d8b17238103483a546c2b6ea..0b45df6edb2118ecb4eed624f62da2870eaef5bd 100644
--- a/net/cert/x509_certificate_unittest.cc
+++ b/net/cert/x509_certificate_unittest.cc
@@ -748,6 +748,16 @@ TEST(X509CertificateTest, IsSelfSigned) {
ImportCertFromFile(certs_dir, "aia-root.pem"));
ASSERT_NE(static_cast<X509Certificate*>(NULL), self_signed.get());
EXPECT_TRUE(X509Certificate::IsSelfSigned(self_signed->os_cert_handle()));
+
+ scoped_refptr<X509Certificate> bad_name(
+ ImportCertFromFile(certs_dir, "self-signed-invalid-name.pem"));
+ ASSERT_NE(static_cast<X509Certificate*>(NULL), bad_name.get());
+ EXPECT_FALSE(X509Certificate::IsSelfSigned(bad_name->os_cert_handle()));
+
+ scoped_refptr<X509Certificate> bad_sig(
+ ImportCertFromFile(certs_dir, "self-signed-invalid-sig.pem"));
+ ASSERT_NE(static_cast<X509Certificate*>(NULL), bad_sig.get());
+ EXPECT_FALSE(X509Certificate::IsSelfSigned(bad_sig->os_cert_handle()));
}
TEST(X509CertificateTest, IsIssuedByEncodedWithIntermediates) {
« no previous file with comments | « net/cert/x509_certificate_openssl.cc ('k') | net/cert/x509_certificate_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698