Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Side by Side Diff: net/cert/x509_certificate_openssl.cc

Issue 1988993002: Check self-signed certificate names and signatures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove dependency on openssl -text format Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/x509_certificate_nss.cc ('k') | net/cert/x509_certificate_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/x509_certificate.h" 5 #include "net/cert/x509_certificate.h"
6 6
7 #include <openssl/asn1.h> 7 #include <openssl/asn1.h>
8 #include <openssl/bytestring.h> 8 #include <openssl/bytestring.h>
9 #include <openssl/crypto.h> 9 #include <openssl/crypto.h>
10 #include <openssl/obj_mac.h> 10 #include <openssl/obj_mac.h>
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 } 449 }
450 450
451 return false; 451 return false;
452 } 452 }
453 453
454 // static 454 // static
455 bool X509Certificate::IsSelfSigned(OSCertHandle cert_handle) { 455 bool X509Certificate::IsSelfSigned(OSCertHandle cert_handle) {
456 crypto::ScopedEVP_PKEY scoped_key(X509_get_pubkey(cert_handle)); 456 crypto::ScopedEVP_PKEY scoped_key(X509_get_pubkey(cert_handle));
457 if (!scoped_key) 457 if (!scoped_key)
458 return false; 458 return false;
459 459 if (!X509_verify(cert_handle, scoped_key.get()))
460 // NOTE: X509_verify() returns 1 in case of success, 0 or -1 on error. 460 return false;
461 return X509_verify(cert_handle, scoped_key.get()) == 1; 461 return X509_check_issued(cert_handle, cert_handle) == X509_V_OK;
462 } 462 }
463 463
464 } // namespace net 464 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/x509_certificate_nss.cc ('k') | net/cert/x509_certificate_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698