Check self-signed certificate names and signatures

net/cert/x509_certificate_openssl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_certificate.h"
 
 #include <openssl/asn1.h>
 #include <openssl/bytestring.h>
 #include <openssl/crypto.h>
 #include <openssl/obj_mac.h>
@@ skipping 440 matching lines @@
   return false;
 }
 
 // static
 bool X509Certificate::IsSelfSigned(OSCertHandle cert_handle) {
   crypto::ScopedEVP_PKEY scoped_key(X509_get_pubkey(cert_handle));
   if (!scoped_key)
     return false;
 
   // NOTE: X509_verify() returns 1 in case of success, 0 or -1 on error.
-  return X509_verify(cert_handle, scoped_key.get()) == 1;
+  if (X509_verify(cert_handle, scoped_key.get()) != 1) {

[estark, 2016/05/20 18:37:53]

same nit about the curly braces

+    return false;
+  }
+  // NOTE: x509_check_issued returns X509_V_OK in case of success
+  if (X509_check_issued(cert_handle, cert_handle) != X509_V_OK) {

[svaldez, 2016/05/20 17:54:52]

Simplify to be the same as _ios comment.

[dadrian, 2016/05/20 19:01:21]

Done.

+    return false;
+  }
+  return true;
 }
 
 }  // namespace net