Check self-signed certificate names and signatures

net/cert/x509_certificate_ios.cc

 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/x509_certificate.h"
 
 #include <CommonCrypto/CommonDigest.h>
 #include <Security/Security.h>
 
 #include <openssl/x509.h>
@@ skipping 450 matching lines @@
 // static
 bool X509Certificate::IsSelfSigned(OSCertHandle os_cert) {
   ScopedX509 cert = OSCertHandleToOpenSSL(os_cert);
   if (!cert)
     return false;
   crypto::ScopedEVP_PKEY scoped_key(X509_get_pubkey(cert.get()));
   if (!scoped_key)
     return false;
 
   // NOTE: X509_verify() returns 1 in case of success, 0 or -1 on error.
-  return X509_verify(cert.get(), scoped_key.get()) == 1;
+  if ((X509_verify(cert.get(), scoped_key.get())) != 1) {

[estark, 2016/05/20 18:37:53]

nit: as much as it pains me personally, use no curly brackets for single-line
bodies to be consistent with the rest of the file

[dadrian, 2016/05/20 19:01:21]

Done, though I wash my hands of all responsibility for goto-fail style bugs :)

+    return false;
+  }
+  // NOTE: x509_check_issued returns X509_V_OK in case of success
+  if (X509_check_issued(cert.get(), cert.get()) != X509_V_OK) {

[svaldez, 2016/05/20 17:54:52]

Consider:
return X509_check_issued...

[dadrian, 2016/05/20 19:01:21]

Done.

+    return false;
+  }
+  return true;
 }
 
 }  // namespace net