Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1988983004: Fix app menu borders for RTL (Closed)

Created:
4 years, 7 months ago by Greg Levin
Modified:
4 years, 7 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix app menu borders for RTL BUG=612485 TEST=Set to RTL language, open main browser (app) menu, observe that button separators in Zoom and Edit rows are properly placed, e.g. [ ] | + 100% - | Zoom Paste | Copy | Cut | Edit Committed: https://crrev.com/e7a1a61e269ba16a335eab35a6eab3e1ae1b30b6 Cr-Commit-Position: refs/heads/master@{#394850}

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -67 lines) Patch
M chrome/browser/ui/views/toolbar/app_menu.cc View 1 8 chunks +26 lines, -67 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Greg Levin
This CL is more code cleanup than bug fix, but the two are directly related, ...
4 years, 7 months ago (2016-05-18 15:26:54 UTC) #2
msw
lgtm with minor nits. I wonder if using explicit separators would really be too ugly, ...
4 years, 7 months ago (2016-05-18 19:10:03 UTC) #3
Greg Levin
> lgtm with minor nits. I wonder if using explicit separators would really be too ...
4 years, 7 months ago (2016-05-19 17:15:39 UTC) #4
msw
still lgtm; thanks
4 years, 7 months ago (2016-05-19 17:21:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988983004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988983004/20001
4 years, 7 months ago (2016-05-19 18:17:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-19 20:44:46 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:46:32 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e7a1a61e269ba16a335eab35a6eab3e1ae1b30b6
Cr-Commit-Position: refs/heads/master@{#394850}

Powered by Google App Engine
This is Rietveld 408576698