Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options' headers."

Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options' headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

This revert leaves the new error code in place, as it had already hit the histogram
file, and we want to ensure that it doesn't start meaning something else inbetween
now and the time at which we reland this patch.

Original commit: https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe7eb063fc43ed

BUG=610284, 555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/21f43dc397b74d88f8d9d5837c12343b834890e6
Cr-Commit-Position: refs/heads/master@{#394707}

[Mike West, 2016-05-17 20:39:12]

Description was changed from

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
==========

to

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mike West, 2016-05-17 20:39:55]

mkwst@chromium.org changed reviewers:
+ creis@chromium.org, mmenke@chromium.org

[Mike West, 2016-05-17 20:39:56]

Charlie, Matt, would you mind stamping this revert while it goes through the
bots?

[mmenke, 2016-05-17 20:45:58]

On 2016/05/17 20:39:56, Mike West (OOO) wrote:
> Charlie, Matt, would you mind stamping this revert while it goes through the
> bots?

net, error_page, content/ LGTM (Though I'm not an expert on NavigationHandle)

[Charlie Reis, 2016-05-17 21:21:34]

Thanks.  content/ LGTM, though there's a compile error in Blink.

[Alexei Svitkine (slow), 2016-05-17 21:22:17]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2016-05-17 21:22:17]

https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:79848: -  <int value="27"
label="BLOCKED_BY_RESPONSE"/>
Nit: Can you keep these values here? So that they don't get re-used and cause
confusion.

[Mike West, 2016-05-18 14:15:10]

On 2016/05/17 at 21:22:17, asvitkine wrote:
>
https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:79848: -  <int value="27"
label="BLOCKED_BY_RESPONSE"/>
> Nit: Can you keep these values here? So that they don't get re-used and cause
confusion.

Should I keep the error code in `net_error_list` as well? I think it might be
confusing to have the ID reserved in histograms.xml, but not present in the
actual list of codes (and I'll need it whenever we come up with a plan for
re-landing this patch... (sometime after I/O))

[mmenke, 2016-05-18 14:54:24]

On 2016/05/18 14:15:10, Mike West (OOO) wrote:
> On 2016/05/17 at 21:22:17, asvitkine wrote:
> >
>
https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/1988933003/diff/1/tools/metrics/histograms/hi...
> > tools/metrics/histograms/histograms.xml:79848: -  <int value="27"
> label="BLOCKED_BY_RESPONSE"/>
> > Nit: Can you keep these values here? So that they don't get re-used and
cause
> confusion.
> 
> Should I keep the error code in `net_error_list` as well? I think it might be
> confusing to have the ID reserved in histograms.xml, but not present in the
> actual list of codes (and I'll need it whenever we come up with a plan for
> re-landing this patch... (sometime after I/O))

Yea, seems weird to keep it in one place, but not the other.  I don't think it
matters much, either way, because the code never made it to stable, but I'm fine
with keeping the net error code.

[Mike West, 2016-05-19 05:49:58]

Description was changed from

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

This revert leaves the new error code in place, as it had already hit the
histogram
file, and we want to ensure that it doesn't start meaning something else
inbetween
now and the time at which we reland this patch.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Mike West, 2016-05-19 05:50:01]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2016-05-19 05:50:01]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1988933003/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-05-19 05:50:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1988933003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1988933003/40001

[commit-bot: I haz the power, 2016-05-19 07:28:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 07:29:29]

Description was changed from

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

This revert leaves the new error code in place, as it had already hit the
histogram
file, and we want to ensure that it doesn't start meaning something else
inbetween
now and the time at which we reland this patch.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert "Introduce AncestorThrottle, which will process 'X-Frame-Options'
headers."

This reverts commit 26a6fc92ae361b4271f8f2197abe7eb063fc43ed, which
broke our handling of 'Content-Disposition' and similar download-triggering
mechanisms for sites like Drive. Which makes me sad.

This revert leaves the new error code in place, as it had already hit the
histogram
file, and we want to ensure that it doesn't start meaning something else
inbetween
now and the time at which we reland this patch.

Original commit:
https://chromium.googlesource.com/chromium/src/+/26a6fc92ae361b4271f8f2197abe...

BUG=610284,555418
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/21f43dc397b74d88f8d9d5837c12343b834890e6
Cr-Commit-Position: refs/heads/master@{#394707}
==========

[commit-bot: I haz the power, 2016-05-19 07:29:30]

Patchset 3 (id:??) landed as
https://crrev.com/21f43dc397b74d88f8d9d5837c12343b834890e6
Cr-Commit-Position: refs/heads/master@{#394707}