Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 198893002: Make supported-xml-content-types.html tests faster. (Closed)

Created:
6 years, 9 months ago by sof
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Make supported-xml-content-types.html tests faster. To try to address Windows test slowness, switch this test over to async XHR requests + split it up into chunks. R=mkwst@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169317

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Split up test into 3 #

Patch Set 4 : More splitting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -144 lines) Patch
M LayoutTests/SlowTests View 1 chunk +0 lines, -1 line 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/resources/supported-xml-content-types.js View 1 2 1 chunk +51 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types.html View 1 2 2 chunks +6 lines, -69 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-expected.txt View 1 2 1 chunk +12 lines, -74 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-invalid-1.html View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-invalid-1-expected.txt View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-invalid-2.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-invalid-2-expected.txt View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-strange-valid-1.html View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-strange-valid-1-expected.txt View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-strange-valid-2.html View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/supported-xml-content-types-strange-valid-2-expected.txt View 1 2 3 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
When you have a moment, please take a look. (Still requires ~2 secs on one ...
6 years, 9 months ago (2014-03-14 15:02:43 UTC) #1
Mike West
LGTM, thanks for splitting this out.
6 years, 9 months ago (2014-03-16 08:12:14 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 9 months ago (2014-03-16 21:38:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/198893002/50001
6 years, 9 months ago (2014-03-16 21:38:45 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-16 22:50:58 UTC) #5
Message was sent while issue was closed.
Change committed as 169317

Powered by Google App Engine
This is Rietveld 408576698