Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 1988883002: Update export_tarball.py (try 2) (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Update export_tarball.py (try 2) - Exclude .git directories only. Stop mentioning SVN. - Exclude the out directory. - Remove obsolete non-essential directories from the list. - Move some non-essential directories to the test data list. - Add a list of essential files to override the non-essential dir list. BUG=611199 Previous CL: https://codereview.chromium.org/1981553002/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300632

Patch Set 1 #

Patch Set 2 : Fix copy + paste error #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M scripts/slave/recipe_modules/chromium/resources/export_tarball.py View 1 6 chunks +27 lines, -33 lines 1 comment Download

Messages

Total messages: 11 (3 generated)
Lei Zhang
4 years, 7 months ago (2016-05-17 18:01:45 UTC) #2
Lei Zhang
Weird, not sure why there's no diff between patch set 1 and 2. If you ...
4 years, 7 months ago (2016-05-17 18:03:02 UTC) #3
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-17 20:50:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1988883002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1988883002/20001
4 years, 7 months ago (2016-05-17 20:58:32 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300632
4 years, 7 months ago (2016-05-17 21:02:29 UTC) #8
qyearsley
On 2016/05/17 at 21:02:29, commit-bot wrote: > Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300632 More failures ...
4 years, 7 months ago (2016-05-18 19:32:28 UTC) #9
Lei Zhang
On 2016/05/18 19:32:28, qyearsley wrote: > On 2016/05/17 at 21:02:29, commit-bot wrote: > > Committed ...
4 years, 7 months ago (2016-05-18 19:43:05 UTC) #10
Lei Zhang
4 years, 7 months ago (2016-05-19 01:30:15 UTC) #11
Message was sent while issue was closed.
Fix - https://codereview.chromium.org/1991563004

https://codereview.chromium.org/1988883002/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/resources/export_tarball.py (right):

https://codereview.chromium.org/1988883002/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/resources/export_tarball.py:55:
'chrome/browser/resources/tracing/tests',
Sigh, this directory does not exist.

Powered by Google App Engine
This is Rietveld 408576698