Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1988853002: When in strong mode, analyze with dart2js paths. (Closed)

Created:
4 years, 7 months ago by scheglov
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

When in strong mode, analyze with dart2js paths. This would correspond to the code in build_sdk_summaries.dart, which creates strong mode summaries. R=brianwilkerson@google.com, paulberry@google.com BUG= https://github.com/dart-lang/sdk/issues/26466 Committed: https://github.com/dart-lang/sdk/commit/34d5d4f55c058c6d39e727b4a59837836334eaef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 7 months ago (2016-05-17 16:41:43 UTC) #1
Paul Berry
lgtm
4 years, 7 months ago (2016-05-17 16:44:49 UTC) #2
Brian Wilkerson
lgtm
4 years, 7 months ago (2016-05-17 16:52:25 UTC) #3
scheglov
4 years, 7 months ago (2016-05-17 19:20:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
34d5d4f55c058c6d39e727b4a59837836334eaef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698